garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-602246497 @nnivruth , Thank you for your updates. The code covers all the cases it seems which is nice. The drawback ATM is that it does not feel very OO. I am wondering if all of this could be implemented in terms of a new utility method called compare(Number, Number) which would allow the isZero, isPositive and isNegative to be implemented by calling compare(aNumber, ZERO). More thinking and experimenting needed... This is all non-trivial, so I think I might cut a 3.10 RC which I am late on and this PR would end up in 3.11.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
