[GitHub] [commons-crypto] vanzin commented on a change in pull request #97: Additional unit tests for JNA, Cipher, Random, Utils testing error inputs

[GitBox]

vanzin commented on a change in pull request #97:
URL: https://github.com/apache/commons-crypto/pull/97#discussion_r413413011



##########
File path: 
src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
##########
@@ -147,6 +153,62 @@ public void cryptoTest() throws Exception {
         }
     }
 
+    @Test(expected = RuntimeException.class)
+    public void testNullTransform() throws Exception {
+        final CryptoCipher cipher = getCipher(null);

Review comment:
       ```suggestion
           getCipher(null);
   ```

##########
File path: 
src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
##########
@@ -147,6 +153,62 @@ public void cryptoTest() throws Exception {
         }
     }
 
+    @Test(expected = RuntimeException.class)
+    public void testNullTransform() throws Exception {
+        final CryptoCipher cipher = getCipher(null);
+    }
+
+    @Test(expected = RuntimeException.class)
+    public void testInvalidTransform() throws Exception {
+        final CryptoCipher cipher = 
getCipher("AES/CBR/NoPadding/garbage/garbage");

Review comment:
       ```suggestion
           getCipher("AES/CBR/NoPadding/garbage/garbage");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org