[
https://issues.apache.org/jira/browse/IMAGING-251?focusedWorklogId=432110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432110
]
ASF GitHub Bot logged work on IMAGING-251:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/20 13:21
Start Date: 08/May/20 13:21
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on a change in pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#discussion_r422139048
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/fp/PaletteEntryForValue.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.tiff.photometricinterpreters.fp;
+
+import java.awt.Color;
+
+/**
+ * Provides a palette entry for a color assignment to a single value. This
class
+ * will assign a color to a value only if it is an exact match for the input.
+ * This class will also support Float.NaN
+ */
+public class PaletteEntryForValue implements IPaletteEntry {
+
+ private final float value;
+ private final int iColor;
+ private final Color color;
+ private boolean isNull;
+
+ /**
+ * Constructs a palette entry for a single value.
+ * <p>
+ * This class will support color-assignments for Float.NaN.
+ *
+ * @param value the color value associated with this palette entry; a
+ * Float.NaN is allowed.
+ * @param color the color assigned to value
+ */
+ public PaletteEntryForValue(float value, Color color) {
+ if (color == null) {
+ throw new IllegalArgumentException("Null colors not allowed");
+ }
+ this.value = value;
+ this.color = color;
+ this.iColor = color.getRGB();
+ isNull = Float.isNaN(value);
+
+ }
+
+ @Override
+ public boolean isCovered(float f) {
+ if (isNull) {
+ return Float.isNaN(f);
+ }
+ return f == value;
+ }
+
+ @Override
+ public int getARGB(float f) {
+ if (isNull) {
+ if (Float.isNaN(f)) {
+ return iColor;
+ }
+ } else {
+ if (f == value) {
+ return iColor;
+ }
+ }
Review comment:
I agree that it would be cleaner to consolidate these blocks as you
recommend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 432110)
Time Spent: 9h (was: 8h 50m)
> Support TIFF standard floating point data
> -----------------------------------------
>
> Key: IMAGING-251
> URL: https://issues.apache.org/jira/browse/IMAGING-251
> Project: Commons Imaging
> Issue Type: New Feature
> Components: Format: TIFF
> Affects Versions: 1.x
> Reporter: Gary Lucas
> Priority: Major
> Fix For: 1.x
>
> Attachments: Imaging252_USGS_n38w077.jpg
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> Commons Imaging does not support the floating-point format included in the
> TIFF specification. There are prominent data sources that issue products in
> this format. The ability to support this information would open up new
> application areas for Commons Imaging.
> TIFF is often used as a mechanism for distributing data from geophysical
> applications in the form of GeoTIFF files. Some of this is not imagery, but
> data. For example, the US Geological Survey is currently releasing
> high-resolution elevation data grids for the 3DEP program under the name
> Cloud-Optimized GeoTIFF (COG). It is a substantial data set with significant
> potential commercial and academic applications.
> To access this data means modifying the TIFF DataReaderStrips and
> DataReaderTile classes to recognize floating point data (which is typically
> indicated using TIFF tag #339, SampleFormat). Also, returning the data in the
> form of a BufferedImage makes no sense at all, so the API on the
> TiffImageParser and supporting classes would need additional methods to
> return arrays of floats. The good news here is that that requirement would
> mean adding new methods to the classes rather than making significant changes
> to existing classes. So the probability of unintended consequences or new
> bugs in existing code would be minimized.
> Specification details for floating-point are given in the main TIFF-6
> documentations and Adobe Photoshop TIFF Technical Note 3.
>
> I am willing to volunteer to make these changes provided that there is
> interest and a high probability that my contributions would be evaluated and,
> if suitable, integrated into the Commons Imaging code base.
> Thank you for your attention in this matter.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
