[
https://issues.apache.org/jira/browse/IMAGING-251?focusedWorklogId=434067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434067
]
ASF GitHub Bot logged work on IMAGING-251:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/20 12:28
Start Date: 16/May/20 12:28
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629638135
Brilliant! Then tomorrow I will finish the review. Final things I'm looking
at are
- test coverage of new code (I lost track of how much is covered here)
- possible issues for security (those `N/0`, or loading values from the data
without checking boundaries, etc)
- how much we broke backward compatibility—if any
If nothing is wrong, then I will just squash. Several ways of doing it I
think; I normally do with `git rebase -i HEAD~N`, where `N` is the number of
commits I want to squash. Doesn't mean we need to squash to a single one, but
we can probably combine a few ones. And add a changelog, and merge :-)
Thanks for updating it so quickly!
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434067)
Time Spent: 12h 50m (was: 12h 40m)
> Support TIFF standard floating point data
> -----------------------------------------
>
> Key: IMAGING-251
> URL: https://issues.apache.org/jira/browse/IMAGING-251
> Project: Commons Imaging
> Issue Type: New Feature
> Components: Format: TIFF
> Affects Versions: 1.x
> Reporter: Gary Lucas
> Priority: Major
> Fix For: 1.x
>
> Attachments: ArizonaHillshade.jpg, Imaging252_USGS_n38w077.jpg
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Commons Imaging does not support the floating-point format included in the
> TIFF specification. There are prominent data sources that issue products in
> this format. The ability to support this information would open up new
> application areas for Commons Imaging.
> TIFF is often used as a mechanism for distributing data from geophysical
> applications in the form of GeoTIFF files. Some of this is not imagery, but
> data. For example, the US Geological Survey is currently releasing
> high-resolution elevation data grids for the 3DEP program under the name
> Cloud-Optimized GeoTIFF (COG). It is a substantial data set with significant
> potential commercial and academic applications.
> To access this data means modifying the TIFF DataReaderStrips and
> DataReaderTile classes to recognize floating point data (which is typically
> indicated using TIFF tag #339, SampleFormat). Also, returning the data in the
> form of a BufferedImage makes no sense at all, so the API on the
> TiffImageParser and supporting classes would need additional methods to
> return arrays of floats. The good news here is that that requirement would
> mean adding new methods to the classes rather than making significant changes
> to existing classes. So the probability of unintended consequences or new
> bugs in existing code would be minimized.
> Specification details for floating-point are given in the main TIFF-6
> documentations and Adobe Photoshop TIFF Technical Note 3.
>
> I am willing to volunteer to make these changes provided that there is
> interest and a high probability that my contributions would be evaluated and,
> if suitable, integrated into the Commons Imaging code base.
> Thank you for your attention in this matter.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
