kinow commented on pull request #72: URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629638135
Brilliant! Then tomorrow I will finish the review. Final things I'm looking at are - test coverage of new code (I lost track of how much is covered here) - possible issues for security (those `N/0`, or loading values from the data without checking boundaries, etc) - how much we broke backward compatibility—if any If nothing is wrong, then I will just squash. Several ways of doing it I think; I normally do with `git rebase -i HEAD~N`, where `N` is the number of commits I want to squash. Doesn't mean we need to squash to a single one, but we can probably combine a few ones. And add a changelog, and merge :-) Thanks for updating it so quickly! Bruno ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
