PeterAlfredLee opened a new pull request #91:
URL: https://github.com/apache/commons-vfs/pull/91


   This PR is to change the currently using zip dependency from `java.util.zip` 
to `Commons Compress`. Including these changes :
   
   1. The `JarFIleObject` no longer extends from `ZipFileObject`, and the 
`JarFileSystem` no longer extends from `ZipFileSystem`. The `jar` module in 
`Commons Compress` could not achieve fit what we need in vfs, cause it did not 
implement some methods like `getCertificates` that are need in vfs. So I have 
decoupled `JarFIleObject/JarFileSystem` from `ZipFileObject/ZipFileSystem`, and 
 moved the methods needed from `ZipFileObject/ZipFileSystem` to 
`JarFIleObject/JarFileSystem`. This change makes `jar` and `zip` two separate 
modules.
   2. The `ZipFile` in `Commons Compress` open zip archivers using 
`Files.newByteChannel`, while the `ZipFile` in 'java.util.zip' is using a 
native method. This means the zip archivers can be safely deleted after reading 
by `ZipFIle` - and some tests are failing now and I have ignored them, say 
`testCannotDeleteWhileStreaming` and `testCannotDeleteWhileStreaming2`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to