XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263
@garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance improvement, it must back it up; some components do this using JMH microbenchmarks, for example please see Apache Commons BCEL, Crypto, CSV, Lang, Math, RNG. I have only experiences using Jprofiler and I don't know how to embed a test with performance in junit. I'll learn about JMH microbenchmarks. thanks. update: I learned how to use it, thanks for your recommendation. also, need I create more tests for testing wether this function is correct? or tests that already exist, which for the older function, is good enough and I need not create more? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
