garydgregory commented on pull request #119:
URL: https://github.com/apache/commons-io/pull/119#issuecomment-637090936


   Yeah, this gets tricky and arbitrary: the class is called "MarkShield" which 
reimplements `mark()` as a noop but it also reimplements `reset()` to throw an 
`IOException`, which feels like a surprise to me (not in a good way.) Why 
should one method be a noop and the other throw an exception? It seems to be 
they both should be noops. WDYT?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to