[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439862 ]
ASF GitHub Bot logged work on LANG-1548: ---------------------------------------- Author: ASF GitHub Bot Created on: 02/Jun/20 02:48 Start Date: 02/Jun/20 02:48 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: <none> # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: <none> # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup Iteration 1: 1830971983.333 ns/op # Warmup Iteration 2: 2188674760.000 ns/op # Warmup Iteration 3: 2181211500.000 ns/op # Warmup Iteration 4: 2349953100.000 ns/op # Warmup Iteration 5: 2360081080.000 ns/op Iteration 1: 2212511940.000 ns/op Iteration 2: 2384214220.000 ns/op Iteration 3: 2227561540.000 ns/op Iteration 4: 2312551740.000 ns/op Iteration 5: 2426368360.000 ns/op # Run progress: 20.00% complete, ETA 00:43:56 # Fork: 2 of 5 # Warmup Iteration 1: 2717844250.000 ns/op # Warmup Iteration 2: 2585462975.000 ns/op # Warmup Iteration 3: 2473264440.000 ns/op # Warmup Iteration 4: 2270443600.000 ns/op # Warmup Iteration 5: 1808085450.000 ns/op Iteration 1: 2028658920.000 ns/op Iteration 2: 2032796820.000 ns/op Iteration 3: 2038743100.000 ns/op Iteration 4: 2217756360.000 ns/op Iteration 5: 2352394580.000 ns/op # Run progress: 23.33% complete, ETA 00:42:08 # Fork: 3 of 5 # Warmup Iteration 1: 2084758120.000 ns/op # Warmup Iteration 2: 1932792450.000 ns/op # Warmup Iteration 3: 2002423360.000 ns/op # Warmup Iteration 4: 2377394140.000 ns/op # Warmup Iteration 5: 2107299380.000 ns/op Iteration 1: 2456784940.000 ns/op Iteration 2: 2353495040.000 ns/op Iteration 3: 2355378120.000 ns/op Iteration 4: 2271070960.000 ns/op Iteration 5: 1892835216.667 ns/op # Run progress: 26.67% complete, ETA 00:40:29 # Fork: 4 of 5 # Warmup Iteration 1: 1807640716.667 ns/op # Warmup Iteration 2: 2016794460.000 ns/op # Warmup Iteration 3: 2198285300.000 ns/op # Warmup Iteration 4: 2100802840.000 ns/op # Warmup Iteration 5: 2311592060.000 ns/op Iteration 1: 2380056300.000 ns/op Iteration 2: 2138964640.000 ns/op Iteration 3: 2291114240.000 ns/op Iteration 4: 2349544800.000 ns/op Iteration 5: 2390796680.000 ns/op # Run progress: 30.00% complete, ETA 00:38:44 # Fork: 5 of 5 # Warmup Iteration 1: 2325848660.000 ns/op # Warmup Iteration 2: 2471929880.000 ns/op # Warmup Iteration 3: 2182010260.000 ns/op # Warmup Iteration 4: 1941523050.000 ns/op # Warmup Iteration 5: 2275766680.000 ns/op Iteration 1: 2225102700.000 ns/op Iteration 2: 2390513420.000 ns/op Iteration 3: 2354390080.000 ns/op Iteration 4: 2202851920.000 ns/op Iteration 5: 2233467340.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld": 2260796959.067 ?99.9%) 107182112.664 ns/op [Average] (min, avg, max) = (1892835216.667, 2260796959.067, 2456784940.000), stdev = 143085053.900 CI (99.9%): [2153614846.403, 2367979071.730] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 439862) Time Spent: 1.5h (was: 1h 20m) > split regionMatches for better performance > ------------------------------------------ > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement > Reporter: JIN XU > Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)