[ https://issues.apache.org/jira/browse/COLLECTIONS-764?focusedWorklogId=440079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440079 ]
ASF GitHub Bot logged work on COLLECTIONS-764: ---------------------------------------------- Author: ASF GitHub Bot Created on: 02/Jun/20 11:49 Start Date: 02/Jun/20 11:49 Worklog Time Spent: 10m Work Description: kinow commented on a change in pull request #165: URL: https://github.com/apache/commons-collections/pull/165#discussion_r433816020 ########## File path: src/main/java/org/apache/commons/collections4/trie/AbstractPatriciaTrie.java ########## @@ -341,10 +341,6 @@ public V selectValue(final K key) { return entry.getValue(); } - /** - * This is equivalent to the other {@link #selectR(TrieEntry, int, Object, int, Cursor, Reference)} - * method but without its overhead because we're selecting only one best matching Entry from the {@link Trie}. - */ Review comment: Ah, you are correct! There was another method, but it was removed when the base class was renamed and the code changed a little bit to create this abstract class - https://github.com/apache/commons-collections/commit/83226e162de60bd22551b1a37cc3e513811e1449#diff-821b6e7d45ec0fd696f3cdc8027f029cL303 All good here then. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 440079) Time Spent: 1h (was: 50m) > Refine javadoc and fix typos > ---------------------------- > > Key: COLLECTIONS-764 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-764 > Project: Commons Collections > Issue Type: Improvement > Reporter: JIN XU > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-collections/pull/165] -- This message was sent by Atlassian Jira (v8.3.4#803005)