[
https://issues.apache.org/jira/browse/LANG-1557?focusedWorklogId=445367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445367
]
ASF GitHub Bot logged work on LANG-1557:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/20 15:11
Start Date: 13/Jun/20 15:11
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #542:
URL: https://github.com/apache/commons-lang/pull/542#discussion_r439746094
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8186,6 +8186,8 @@ public static String strip(String str, final String
stripChars) {
return stripEnd(str, stripChars);
}
+ private static final Pattern STRIP_ACCENTS_PATTERN =
Pattern.compile("\\p{InCombiningDiacriticalMarks}+"); //$NON-NLS-1$
Review comment:
@garydgregory
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 445367)
Time Spent: 20m (was: 10m)
> change a Pattern to a static final field, for not letting it compile each
> time the function invoked.
> ----------------------------------------------------------------------------------------------------
>
> Key: LANG-1557
> URL: https://issues.apache.org/jira/browse/LANG-1557
> Project: Commons Lang
> Issue Type: Sub-task
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/542]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
