[
https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166644#comment-17166644
]
Phil Steitz commented on DBCP-559:
----------------------------------
This looks reasonable to me. The change is just to add an "open" method to BDS
that sets closed to false, which will effectively cause the datasource to
re-initialize itself when getConnection is called. The change to the JMX class
is just to expose the method. Seems a safe and useful change to me, unless I
am missing something. It might be best to change the name to "start" and maybe
also expose "stop" and "restart" via JMX. Does anyone see any reason not to
add these methods?
> 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
> -------------------------------------------------------------------
>
> Key: DBCP-559
> URL: https://issues.apache.org/jira/browse/DBCP-559
> Project: Commons DBCP
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Wenzhi Ji
> Priority: Major
> Labels: ready-to-commit
> Fix For: 2.8.0
>
> Attachments: BasicDataSource.java, BasicDataSourceMXBean.java
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。
> 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed
> = false；以使建立的数据库连接生效。
> 变更的代码见附件。
> 注：附件是基于2.7.0版本代码进行优化的。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
