[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=464209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464209
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/20 17:48
Start Date: 29/Jul/20 17:48
Worklog Time Spent: 10m
Work Description: sebbASF edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-665748884
It occurs to me that the code is effectively buffering the output from a
BufferedReader (or BufferedInputStream).
One would expect these classes to be reasonably fast, however the JVM has to
do locking and other checks in order to support multi-threading. It has to do
this for each read() call.
Rather than implement the buffering directly in the compare methods, it
might be better to implement a generic, non-threadsafe buffered reader/stream
that can be used in situations such as these. [No need to wrap the original
input in a buffered version first]. It would be a non-threadsafe version of
BufferedReader/InputStream.
The original code should then work without any change other than to add the
filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 464209)
Time Spent: 5h 10m (was: 5h)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
