[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=465990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465990
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/20 01:57
Start Date: 04/Aug/20 01:57
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-668333108
On Mon, Aug 3, 2020 at 7:42 PM sebbASF <notificati...@github.com> wrote:
> The original comparison methods are easy to follow.
> It would be good to keep the same clarity by defining new versions of
> BufferedReader that have good single-threaded performance. Such classes
> would also be useful elsewhere.
> So for example
> BufferedReader bufferedInput1 = toBufferedReader(input1);
> would become something like:
> FastBufferedReader bufferedInput1 = toFastBuffer(input1) (*)
>
> where toFastBuffer() works like buffer() but returns an instance of a
> non-threadsafe FastBufferedReader.
>
> The FastBufferedxxx classes would also be useful in their own right
> elsewhere in IO.
> Obviously the documentation would need to make it clear that they are not
> thread-safe.
> I suspect they don't need to implement mark (which would make them
> simpler).
>
> (*) FastBuffer is just a suggestion for the name. Maybe QandDBuffer would
> be better (Quick and Dirty)!
>
I would really like to stay away from names like "Fast". Faster than what?
What if we come up with something better but incompatible, would that be a
"FasterThanFast" or "Fastest" ;-)
We've run into this kind naming issue before and we decide to go with a
prefix that describes the actual functionality which is "unsynchronized",
see
- org.apache.commons.io.input.UnsynchronizedByteArrayInputStream
- org.apache.commons.io.output.UnsynchronizedByteArrayOutputStream
Note that there is precedent for this kind of name in the JRE's copy of
Apache's XML code:
- com.sun.org.apache.xml.internal.security.utils.UnsyncBufferedOutputStream
- com.sun.org.apache.xml.internal.security.utils.UnsyncByteArrayOutputStream
Gary
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-io/pull/118#issuecomment-668293267>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAJB6N7FXXKQAFHZ5JBELY3R65DPFANCNFSM4NP6TZTQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 465990)
Time Spent: 7.5h (was: 7h 20m)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
