XenoAmess commented on a change in pull request #118:
URL: https://github.com/apache/commons-io/pull/118#discussion_r465659496
##########
File path: src/test/java/org/apache/commons/io/IOUtilsTestCase.java
##########
@@ -311,28 +314,38 @@ public synchronized void close() throws IOException {
assertTrue(IOUtils.contentEqualsIgnoreEOL(input1, input1));
}
- Reader r1;
- Reader r2;
-
- r1 = new CharArrayReader("".toCharArray());
- r2 = new CharArrayReader("".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("1".toCharArray());
- r2 = new CharArrayReader("1".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("1".toCharArray());
- r2 = new CharArrayReader("2".toCharArray());
- assertFalse(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("123\rabc".toCharArray());
- r2 = new CharArrayReader("123\nabc".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
-
- r1 = new CharArrayReader("321".toCharArray());
- r2 = new CharArrayReader("321\r\n".toCharArray());
- assertTrue(IOUtils.contentEqualsIgnoreEOL(r1, r2));
+ testSingleEOL("", "", true);
+ testSingleEOL("", "\n", true);
+ testSingleEOL("", "\r", true);
+ testSingleEOL("", "\r\n", true);
+ testSingleEOL("", "\r\r", false);
+ testSingleEOL("", "\n\n", false);
+ testSingleEOL("1", "1", true);
+ testSingleEOL("1", "2", false);
+ testSingleEOL("123\rabc", "123\nabc", true);
+ testSingleEOL("321", "321\r\n", true);
+ testSingleEOL("321", "321\r\naabb", false);
+ testSingleEOL("321", "321\n", true);
+ testSingleEOL("321", "321\r", true);
+ testSingleEOL("321", "321\r\n", true);
+ testSingleEOL("321", "321\r\r", false);
+ testSingleEOL("321", "321\n\r", false);
+ testSingleEOL("321\n", "321", true);
+ testSingleEOL("321\n", "321\n\r", false);
+ testSingleEOL("321\n", "321\r\n", true);
+ testSingleEOL("321\r", "321\r\n", true);
+ testSingleEOL("321\r\n", "321\r\n\r", false);
+ testSingleEOL("123", "1234", false);
+ }
+
Review comment:
@sebbASF
pr created at
https://github.com/apache/commons-io/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
