kinow commented on pull request #37: URL: https://github.com/apache/commons-configuration/pull/37#issuecomment-678000099
I applied @aherbert's suggestion in his last comment in CONFIGURATION-766 locally, and it worked with no issues. That approach looks good to me, modifying the `toBigDecimal` in `PropertyConverter`. @HarisAdzemovic if you update the unit tests to use `BigDecimal.valueOf(d)` instead of `new BigDecimal(d)` and then apply @aherbert 's patch, this PR should be ready to be merged IMO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org