[ 
https://issues.apache.org/jira/browse/LANG-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183732#comment-17183732
 ] 

Jin Xu commented on LANG-1598:
------------------------------

Agreed this idea, but it is a HUGE work if we want to add NotNull and Nullable 
to all public functions in commons-lang.
Also I'd prefer using jetbrains Annotations

{code:java}
            <dependency>
                <groupId>org.jetbrains</groupId>
                <artifactId>annotations</artifactId>
                <version>20.0.0</version>
                <scope>provided</scope>
            </dependency>
{code}
for example.

Well it might not be politely but I really doubt any java codes from google 
people.
I had a bad experience in handling a really awful google java repo, so I just, 
don't think google people can write normal java codes.

> Use JSR-305 (javax.annotation) for Null-Analysis to avoid unexpected 
> NullPointerExceptions
> ------------------------------------------------------------------------------------------
>
>                 Key: LANG-1598
>                 URL: https://issues.apache.org/jira/browse/LANG-1598
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.11
>            Reporter: Alexander Guril
>            Priority: Major
>              Labels: newbie
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Use the javax.annotation-API for Null-Analysis to avoid NPEs.
> {code:XML}
> <!-- https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305 -->
> <dependency>
>     <groupId>com.google.code.findbugs</groupId>
>     <artifactId>jsr305</artifactId>
>     <version>3.0.2</version>
> </dependency>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to