[jira] [Work logged] (NUMBERS-152) add a private constructor for already known reduced num and den, to avoid unneeded gcd.

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/NUMBERS-152?focusedWorklogId=474673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474673
 ]

ASF GitHub Bot logged work on NUMBERS-152:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Aug/20 05:44
            Start Date: 26/Aug/20 05:44
    Worklog Time Spent: 10m 
      Work Description: coveralls edited a comment on pull request #85:
URL: https://github.com/apache/commons-numbers/pull/85#issuecomment-680644579


   
   [![Coverage 
Status](https://coveralls.io/builds/33005973/badge)](https://coveralls.io/builds/33005973)
   
   Coverage increased (+0.001%) to 99.636% when pulling 
**7bcfe183ec6df94aac94b5f64a240cdcc943f6d9 on 
XenoAmess:add_non_reduce_constructor_for_Fraction** into 
**c3d173ae9cf25329644b87b8e064f56a2c31ea53 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 474673)
    Time Spent: 1h  (was: 50m)

> add a private constructor for already known reduced num and den, to avoid 
> unneeded gcd.
> ---------------------------------------------------------------------------------------
>
>                 Key: NUMBERS-152
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-152
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: fraction
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> https://github.com/apache/commons-numbers/pull/85
> currently, even if we already know the num and den be already reduced, we 
> must run a gcd when creating the Fraction object.
> I think we can provide a private constructor, specially for situations when 
> we can make sure the num and den be already reduced, then we do not invoke 
> the additional gcd round.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)