[
https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=495839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495839
]
ASF GitHub Bot logged work on IMAGING-265:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 11:18
Start Date: 06/Oct/20 11:18
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on pull request #98:
URL: https://github.com/apache/commons-imaging/pull/98#issuecomment-704201263
Okay. I will update the pull request to use the TiffPlanarConfiguration
enumerated type.
On Tue, Oct 6, 2020, 6:50 AM Bruno P. Kinoshita <notificati...@github.com>
wrote:
> *@kinow* commented on this pull request.
> ------------------------------
>
> In
> src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
> <https://github.com/apache/commons-imaging/pull/98#discussion_r500180247>:
>
> > @@ -53,14 +53,17 @@ public boolean stripsNotTiles() {
>
> @Override
> public ImageDataReader getDataReader(final TiffDirectory
directory,
> - final PhotometricInterpreter photometricInterpreter,
> - final int bitsPerPixel, final int[] bitsPerSample, final
int predictor,
> - final int samplesPerPixel, final int width, final int
height, final int compression,
> - final ByteOrder byteOrder) throws IOException,
ImageReadException {
> + final PhotometricInterpreter photometricInterpreter,
> + final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
> + final int samplesPerPixel, final int width, final int height,
> + final int compression,
> + final int planarConfiguration,
>
> Making planar configuration an enum would be a good idea. I see that you
> self-assigned this. Does that mean you'll be making the change?
>
> No, sorry it's just an old habit. I believe I cannot assign the issue to
> you as you are an external contributor. I normally assign issues & PR's to
> myself so other common developers are aware I'm interested in
> working/finishing work on some issue.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-imaging/pull/98#discussion_r500180247>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AEWJDYNAE7UN6M2CJ2M7WQTSJLY57ANCNFSM4RSXZ7OQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 495839)
Time Spent: 2h 40m (was: 2.5h)
> ArrayIndexOutOfBoundsException on reading simple GeoTIFF
> --------------------------------------------------------
>
> Key: IMAGING-265
> URL: https://issues.apache.org/jira/browse/IMAGING-265
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: TIFF
> Affects Versions: 1.0-alpha2
> Reporter: edgar soldin
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Attachments: small_world.tif, small_world_split.jpg
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> hi,
>
> we on the OpenJUMP project cannot open some GeoTIFFs with commons.imaging .
> for details you may find a ticket in our bug tracker
> [https://sourceforge.net/p/jump-pilot/bugs/498/] .
>
> the gist is: on loading the attached file getBufferedImage() fails with this
> stack
> {noformat}
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 8000Caused by:
> java.lang.ArrayIndexOutOfBoundsException: 8000 at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.interpretStrip(DataReaderStrips.java:196)
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.readImageData(DataReaderStrips.java:254)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:665)
> at
> org.apache.commons.imaging.formats.tiff.TiffDirectory.getTiffImage(TiffDirectory.java:254)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:469)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1442) at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1335) at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1304) at
> com.vividsolutions.jump.workbench.imagery.graphic.CommonsImage.initImage(CommonsImage.java:108){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
