aherbert commented on a change in pull request #195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r526836141
##########
File path: src/main/java/org/apache/commons/collections4/IterableUtils.java
##########
@@ -50,6 +50,11 @@
*/
public class IterableUtils {
+ /**
+ * {@code IterableUtils} should not normally be instantiated.
+ */
+ private IterableUtils() {}
+
Review comment:
Perhaps make the constructor public and mark it as deprecated for
removal in 5.0 with a note that the class is not intended to be instantiated.
This will clarify the intention and ensure the change does happen when 5.0 is
released as all deprecated tags will be addressed on a major version increment.
Or remove this from the PR as binary compatibility is an important goal of
commons within major versions, even for something trivial like this where the
use cases of instances of this class are non-existent and I think it unlikely
that any end user would be creating instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
