[
https://issues.apache.org/jira/browse/COLLECTIONS-772?focusedWorklogId=514280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514280
]
ASF GitHub Bot logged work on COLLECTIONS-772:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/20 18:46
Start Date: 19/Nov/20 18:46
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#195:
URL:
https://github.com/apache/commons-collections/pull/195#discussion_r527117836
##########
File path: src/main/java/org/apache/commons/collections4/IterableUtils.java
##########
@@ -50,6 +50,11 @@
*/
public class IterableUtils {
+ /**
+ * {@code IterableUtils} should not normally be instantiated.
+ */
+ private IterableUtils() {}
+
Review comment:
Hi,
I have reverted the changes of the class IterableUtils. Although I think it
is necessary to match all the constructors to private access
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 514280)
Time Spent: 1h 20m (was: 1h 10m)
> Provide private constructor to the Utils Collections
> ----------------------------------------------------
>
> Key: COLLECTIONS-772
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-772
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
> Affects Versions: 4.4
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Utils classes have their constructor made private to prohibit instantiation.
>
> * IterableUtils
> * ArrayUtils
>
> {color:#ff0000}Keep in mind this improvement will break the binary. We need a
> mayor release{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
