[
https://issues.apache.org/jira/browse/CRYPTO-151?focusedWorklogId=520758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-520758
]
ASF GitHub Bot logged work on CRYPTO-151:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/20 14:09
Start Date: 06/Dec/20 14:09
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#discussion_r537046441
##########
File path:
src/test/java/org/apache/commons/crypto/stream/PositionedCryptoInputStreamTest.java
##########
@@ -247,7 +250,7 @@ private void testSeekFailed(final String cipherClass, final
int position, final
getCipher(cipherClass), bufferSize);
try {
in.seek(position);
- Assert.fail("Excepted exception for cannot seek to negative
offset.");
+ fail("Excepted exception for cannot seek to negative offset.");
} catch (final IllegalArgumentException iae) {
Review comment:
Hi @arturobernalg
Thank you for your PR.
If we go to JUnit 5, then let's remove this pattern with `assertThrows()`
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 520758)
Time Spent: 1h (was: 50m)
> Migrate to Junit 5
> ------------------
>
> Key: CRYPTO-151
> URL: https://issues.apache.org/jira/browse/CRYPTO-151
> Project: Commons Crypto
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
