garydgregory commented on pull request #114: URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-743781742
> Hi @garydgregory > As you can imaginate I don't think validating the exception message will helps with the functional testing. But in any case, i made the revert and adapt to JUnit 5. > I've check of all the new change @arturobernalg Maybe so, but this is a large PR that is _supposed_ to only _port_ the tests from JUnit 4 to 5, so it is best IMO to _not_ change _what_ is being tested or _how_ it is being tested. As you can imagine, it's a slog to go through a large PR ;-) If you want to improve the tests beyond this port, then sure go ahead, but I don't see a case for removing something successfully tested for now. Gary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
