PeterAlfredLee commented on a change in pull request #157:
URL: https://github.com/apache/commons-compress/pull/157#discussion_r542161610
##########
File path:
src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java
##########
@@ -137,14 +137,15 @@ private long writeEntryHeader(final ArArchiveEntry
pEntry) throws IOException {
boolean mustAppendName = false;
final String n = pEntry.getName();
- if (LONGFILE_ERROR == longFileMode && n.length() > 16) {
+ final int nLength = n.length();
Review comment:
I can't see much benefit from extracting `n.length()` to a final
`nlength`. Maybe it's performance benefiting or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
