garydgregory edited a comment on pull request #20: URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-756145639
The big issue with kind of PR is that it undoes a previous intentional fix which was not unit tested. This PR does not have a unit test either so we are just going back and forth between different behaviors. Ideally we need to start with some docs on what the expectations should be on on the contracts provided by not only the interfaces but by classes like this abstract class which is reused all over. IOW, I would not change anything until we establish or relearn what the ground rules and expectations are WRT thread-safety as it seems reasonable for this abstract class to enforce or help establish thread safety or the lack of it... @rgoers any thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
