garydgregory commented on a change in pull request #129:
URL: https://github.com/apache/commons-crypto/pull/129#discussion_r553992160
##########
File path: src/main/java/org/apache/commons/crypto/utils/ReflectionUtils.java
##########
@@ -30,7 +32,7 @@
*/
public final class ReflectionUtils {
- private static final Map<ClassLoader, Map<String,
WeakReference<Class<?>>>> CACHE_CLASSES = new WeakHashMap<>();
+ private static final ConcurrentMap<ClassLoader, Map<String,
WeakReference<Class<?>>>> CACHE_CLASSES = new ConcurrentHashMap<>();
Review comment:
I don't think you've thought through the consequences of this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
