garydgregory commented on a change in pull request #72:
URL: https://github.com/apache/commons-net/pull/72#discussion_r565484374
##########
File path: src/main/java/org/apache/commons/net/ftp/FTP.java
##########
@@ -215,6 +215,11 @@
private static final String modes = "AEILNTCFRPSBC";
+ /**
+ * An empty immutable {@code String} array.
+ */
+ private static final String[] EMPTY_STRING_ARRAY = new String[0];
Review comment:
-1 We don't need duplicate constants in the same package all over the
place. Just make one of them _package private_ like the one in `FTP` and reuse
it. If there are a lot of these constants, it might be worth creating a public
`NetConstants` class `org.apache.commons.net.util, I'll let you poke around ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
