boris-unckel commented on pull request #192: URL: https://github.com/apache/commons-io/pull/192#issuecomment-768802353
@garydgregory Thank you for your time to review and place it for public review. > If the pause happened before the assert, the assert catches something... if it happens after, I know nothing and my app calling Commons IO _still_ needs to handle the situation, assert or no assert. The use case you're describing is not improved by the assert or just slightly. I'm thinking more about cases where the underlying file system in combination with the JRE does not behave as expected: The following is a plain vanilla Fedora 33 with ext4 filesystem. Unfortunately in German :-( For /tmp it says "IOCTL not matching to read flags of /tmp". `sudo lsattr / [sudo] Passwort für borisunckel: -----------I--e----- /etc lsattr: Unpassender IOCTL (I/O-Control) für das Gerät Beim Lesen der Flags von /run lsattr: Die Operation wird nicht unterstützt Beim Lesen der Flags von /lib64 --------------e----- /lost+found lsattr: Unpassender IOCTL (I/O-Control) für das Gerät Beim Lesen der Flags von /sys --------------e----- /usr lsattr: Unpassender IOCTL (I/O-Control) für das Gerät Beim Lesen der Flags von /proc --------------e----- /mnt lsattr: Die Operation wird nicht unterstützt Beim Lesen der Flags von /sbin --------------e----- /srv lsattr: Die Operation wird nicht unterstützt Beim Lesen der Flags von /lib lsattr: Unpassender IOCTL (I/O-Control) für das Gerät Beim Lesen der Flags von /tmp lsattr: Die Operation wird nicht unterstützt Beim Lesen der Flags von /bin --------------e----- /root --------------e----- /media --------------e----- /var --------------e----- /home lsattr: Unpassender IOCTL (I/O-Control) für das Gerät Beim Lesen der Flags von /dev --------------e----- /boot --------------e----- /opt ` Working with commons-io 2.5 I had no trouble to build WildFly-Core, with 2.8.0 it fails. The first fixes I already provided (former PRs not this one), but it is not over. The asserts help to find the original place of fail and not the top level one (like "delete fails due to directory is not empty"). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
