[
https://issues.apache.org/jira/browse/IO-711?focusedWorklogId=543884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543884
]
ASF GitHub Bot logged work on IO-711:
-------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/21 21:10
Start Date: 28/Jan/21 21:10
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #196:
URL: https://github.com/apache/commons-io/pull/196#issuecomment-769397122
> @garydgregory Please review and mark the cases you don't want to change
for compatibility and/or design reasons. I'll change then all occurrences
accordingly.
Hi @boris-unckel
Sorry but I don't want to take the time to review each change in each of 31
files. If you do not want to revise the PR to minimize changes and duplication
of null checks, that's fine as well. I might get to these kinds of changes
later. Thank you for your contributions so far though :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 543884)
Time Spent: 40m (was: 0.5h)
> Use Objects.requireNotNull for fail fast method/constructors
> ------------------------------------------------------------
>
> Key: IO-711
> URL: https://issues.apache.org/jira/browse/IO-711
> Project: Commons IO
> Issue Type: Improvement
> Components: Filters, Streams/Writers, Utilities
> Affects Versions: 2.8.0
> Reporter: Boris Unckel
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently some NullPointer checks are IllegalArgumentException, at other
> points a lot of constructor and/or method logic happens before a null pointer
> occurs.
> The approach is to make these places use
> Objects.requireNonNull(sampleObject,"sampleObject");
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
