[GitHub] [commons-lang] mdbuck77 commented on a change in pull request #703: LANG-1641: GmtTimeZone now implements #equals(Object) using it's time…

[GitBox]

mdbuck77 commented on a change in pull request #703:
URL: https://github.com/apache/commons-lang/pull/703#discussion_r571429319



##########
File path: src/main/java/org/apache/commons/lang3/time/GmtTimeZone.java
##########
@@ -33,8 +35,7 @@
     // Serializable!
     static final long serialVersionUID = 1L;
 
-    private final int offset;
-    private final String zoneId;
+    private final SimpleTimeZone m_delegate;
 

Review comment:
       done

##########
File path: src/main/java/org/apache/commons/lang3/time/GmtTimeZone.java
##########
@@ -67,39 +69,43 @@ public void setRawOffset(final int offsetMillis) {
 
     @Override
     public int getRawOffset() {
-        return offset;
+        return m_delegate.getRawOffset();
     }
 
     @Override
     public String getID() {
-        return zoneId;
+        return m_delegate.getID();
     }
 
     @Override
     public boolean useDaylightTime() {
-        return false;
+        return m_delegate.useDaylightTime();
     }
 
     @Override
     public boolean inDaylightTime(final Date date) {
-        return false;
+        return m_delegate.inDaylightTime(date);
     }
 
     @Override
     public String toString() {
-        return "[GmtTimeZone id=\"" + zoneId + "\",offset=" + offset + ']';
+        return "[GmtTimeZone id=\"" + getID() + "\",offset=" + getRawOffset() 
+ ']';
     }
 
     @Override
-    public int hashCode() {
-        return offset;
+    public boolean equals(Object o) {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {

Review comment:
       I made the class final.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org