aherbert commented on pull request #26:
URL: https://github.com/apache/commons-statistics/pull/26#issuecomment-782818168
I agree with the parameterised tests. This is a change that can be
implemented later. We can discuss the approach on the mailing list.
I think the `TOO_LARGE` and `TOO_SMALL` apply when one of the arguments is
fixed and the other is incorrect relative to it. The case here is for a range
that is not specified correctly. So perhaps we should use an `INVALID_RANGE`
exception where the upper bound is not above the lower bound:
`Lower bound %s is not below the upper bound %s`
This allows you to specify the range arguments in their declared order:
```java
if (upper <= lower) {
throw new DistributionException(DistributionException.INVALID_RANGE,
lower, upper);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
