[ https://issues.apache.org/jira/browse/IO-651?focusedWorklogId=555839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555839 ]
ASF GitHub Bot logged work on IO-651: ------------------------------------- Author: ASF GitHub Bot Created on: 22/Feb/21 14:42 Start Date: 22/Feb/21 14:42 Worklog Time Spent: 10m Work Description: jmark109 commented on a change in pull request #206: URL: https://github.com/apache/commons-io/pull/206#discussion_r580302602 ########## File path: src/test/java/org/apache/commons/io/output/DeferredFileOutputStreamTest.java ########## @@ -365,4 +370,55 @@ private void verifyResultFile(final File testFile) { fail("Unexpected IOException"); } } + + /** + * Tests the case where the amount of data falls below the threshold, and is therefore confined to memory. + * Testing the getInputStream() method. + */ + @ParameterizedTest(name = "initialBufferSize = {0}") + @MethodSource("data") + public void testBelowThresholdGetInputStream(final int initialBufferSize) throws IOException { + final DeferredFileOutputStream dfos = new DeferredFileOutputStream(testBytes.length + 42, initialBufferSize, Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 555839) Time Spent: 3h (was: 2h 50m) > Provide method to retrieve data from DeferredFileOutputStream as InputStream > ---------------------------------------------------------------------------- > > Key: IO-651 > URL: https://issues.apache.org/jira/browse/IO-651 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers > Affects Versions: 2.6 > Reporter: John Mark > Priority: Major > Labels: easyfix, performance, pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > It would be very helpful to have to {{toInputStream()}} method on the > {{DeferredFileOutputStream}} class. Besides for convenience, it would allow > for improved efficiency since in the case of in-memory data the byte buffer > would not need to be copied (as opposed to the current {{getData()}} method). > The implementation is pretty simple and can be something like the following > (based on the current {{writeTo(OutputStream)}} method): > {code:java} > public InputStream toInputStream() throws IOException { > if (!closed) { > throw new IOException("Stream not closed"); > } > if (isInMemory()) { > return memoryOutputStream.toInputStream(); > } else { > return Files.newInputStream(outputFile.toPath()); > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)