[
https://issues.apache.org/jira/browse/LANG-1649?focusedWorklogId=567702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567702
]
ASF GitHub Bot logged work on LANG-1649:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/21 14:25
Start Date: 17/Mar/21 14:25
Worklog Time Spent: 10m
Work Description: arturobernalg edited a comment on pull request #731:
URL: https://github.com/apache/commons-lang/pull/731#issuecomment-801104206
> There are more rules to check here. You should also check the method is
not **final** using `Modifier.isFinal` which prevents being overridden.
>
> How to handle static methods is an issue. You cannot create an
**instance** method in a subclass with the same signature as a **static**
method from the super class. But you can create a **static** method with the
same signature. The static methods are not dispatched on an object at runtime.
The method to use is chosen by the compiler.
>
> So perhaps this should return false for any method with the static or
final modifiers.
Hi @aherbert
I completely forgot about the final. I have change the validation in order
to return false when the method it's static or final.
TY
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 567702)
Time Spent: 1h 10m (was: 1h)
> Check if method is Overridable
> ------------------------------
>
> Key: LANG-1649
> URL: https://issues.apache.org/jira/browse/LANG-1649
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
> Affects Versions: 3.12.0
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Create a method that Check if the given Method is overridable in the given a
> Class
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
