[
http://jira.codehaus.org/browse/CONTINUUM-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250484#action_250484
]
Maria Odea Ching commented on CONTINUUM-2600:
---------------------------------------------
Hi Mark, please see comments below:
{quote}
Index:
continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
===================================================================
---
continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
(revision 1054517)
+++
continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
(working copy)
@@ -2201,9 +2201,21 @@
private BuildAgentConfiguration populateBuildAgent(
org.apache.continuum.configuration.BuildAgentConfiguration buildAgent )
{
- return (BuildAgentConfiguration) mapper.map( buildAgent,
BuildAgentConfiguration.class );
+ BuildAgentConfiguration buildAgentConfiguration =
+ (BuildAgentConfiguration) mapper.map( buildAgent,
BuildAgentConfiguration.class );
+ try
+ {
+ buildAgentConfiguration.setPlatform(
distributedBuildManager.getbuildAgentPlatform( buildAgentConfiguration.getUrl()
) );
+ return buildAgentConfiguration;
+ }
+ catch ( ContinuumException e )
+ {
+ buildAgentConfiguration.setPlatform( "" );
+ return buildAgentConfiguration;
+ }
}
{quote}
* Can you log the error/exception being swallowed when getting the build
agent's platform?
{quote}
Index:
continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java
===================================================================
---
continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java
(revision 1054517)
+++
continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java
(working copy)
@@ -48,6 +48,9 @@
List<Installation> getAvailableInstallations( String buildAgentUrl )
throws ContinuumException;
+
+ String getbuildAgentPlatform( String buildAgentUrl )
+ throws ContinuumException;
{quote}
* Can you make the method name camel-cased (e.g. getBuildAgentPlatform(...) )?
* Can you also provide unit tests for new method you added for the distributed
build manager?
Thanks!
> Include in webservice to also return platform of buildagent when retrieving a
> buildagent or list of buildagents
> ---------------------------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-2600
> URL: http://jira.codehaus.org/browse/CONTINUUM-2600
> Project: Continuum
> Issue Type: New Feature
> Reporter: Mark John Kenedy L. Magallanes
> Attachments: CONTINUUM-2600.patch
>
>
> Right now there is no current way on getting the platform of the build agent
> adding an additional field "platform" to the model of the
> buildagentconfiguration used in the webservice in getting
> buildagent/buildagents would be very useful for making platform specific
> jobs. The platform of the buildagent can be retrieve through it's webservice
> that is done in this issue http://jira.codehaus.org/browse/CONTINUUM-2597.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
