[ 
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592807#comment-13592807
 ] 

Jesse MacFadyen commented on CB-2606:
-------------------------------------

I think the folks behind build.phonegap.com have already done the legwork on 
this.  See https://build.phonegap.com/docs/config-xml

<icon src="icon.png" />
<icon src="icons/ios/icon.png" gap:platform="ios" width="57" height="57" />
<icon src="icons/ios/icon-72.png" gap:platform="ios" width="72" height="72" />
<icon src="icons/ios/icon_at_2x.png" gap:platform="ios" width="114" 
height="114" />
<icon src="icons/android/ldpi.png" gap:platform="android" gap:density="ldpi" />
<icon src="icons/android/mdpi.png" gap:platform="android" gap:density="mdpi" />
<icon src="icons/android/hdpi.png" gap:platform="android" gap:density="hdpi" />
<icon src="icons/android/xhdpi.png" gap:platform="android" gap:density="xhdpi" 
/>
<icon src="icons/bb/icon.png" gap:platform="blackberry" />
<icon src="icons/bb/icon_hover.png" gap:platform="blackberry" 
gap:state="hover"/>
<icon src="icons/winphone/icon.png" gap:platform="winphone" />
<icon src="icons/winphone/tileicon.png" gap:platform="winphone" 
gap:role="background" />
<icon src="icons/webos/icon.png" gap:platform="webos" />
<icon src="icons/webos/miniicon.png" gap:platform="webos" gap:role="mini" />

Admittedly it is not awesome, but it is 'close' to that spec, and it does 
accomplish what needs to be defined. It would be nice to remove some of the 
differences between gap:state, gap:density, gap:role ...

The gap:platform makes sense, but ideally Apache Cordova would use 
cordova:platform.


If we wanted to avoid the declarative mess, the only reasonable approach I see 
is simply having default names for everything, and defining/documenting them.

Something like:
<icon src="icons/" /> 

And within icons:

* icons/
** ios/
*** icon.png
*** icon-72.png
*** i...@2x.png
** android/
*** icon-ldpi.png
** bb/
** winphone/
** webos/




                
> Add support for <icon> elements in config.xml
> ---------------------------------------------
>
>                 Key: CB-2606
>                 URL: https://issues.apache.org/jira/browse/CB-2606
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Docs
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>             Fix For: 2.6.0
>
>
> This feature would add support for specifying the application icon by 
> changing values inside the {{config.xml}} document.
> Relevant details for Cordova:
> - {{<icon>}} elements _may_ have {{width}} and {{height}} attributes 
> representing the preferred size of the icon in CSS pixels.
> - {{<icon>}} elements _must_ have a {{src}} attribute, which contains a path 
> string relative to the {{www/}} folder (or equivalent) in the platform.
> See [the Widget Spec's section on 
> icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for 
> specifics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to