erisu opened a new pull request #162: URL: https://github.com/apache/cordova-electron/pull/162
### Motivation, Context & Description There are possibilities that the Cordova-Lib's version of Cordova-Common does not matching the platform's version. There can be cases where the platform introduces supporting logic in common and pins itself to use the new version. A good example where this case happened in the past was with Adaptive Icons in Cordova Android. Supportive logic was added to common and the platform was pinned but anyone who used the latest platform had issues with adaptive icon because the Lib version was old. It is expected that platform's common can be updated to a version that lib does not use. This PR will recreate the common object during prepare with the platform's installed common. ### Testing - `npm t` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I updated automated test coverage as appropriate for this change ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
