[
https://issues.apache.org/jira/browse/CB-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721056#comment-13721056
]
mike billau commented on CB-3762:
---------------------------------
Hi, thanks, I agree with you guys. I've submitted pull requests and tested on
Android using mobile spec. I don't think that this is really an API change
since everything still works the same, except now if somebody was not using a
text hint, instead of "Default text" appearing in the text box, it will just be
blank.
JS fix: https://github.com/apache/cordova-plugin-dialogs/pull/2
doc fix: https://github.com/apache/cordova-docs/pull/87
> notification.prompt doesn't accept an empty string for default text
> -------------------------------------------------------------------
>
> Key: CB-3762
> URL: https://issues.apache.org/jira/browse/CB-3762
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
> Affects Versions: 2.7.0, 2.8.0
> Reporter: Todd Miller
> Assignee: Steve Gill
> Priority: Minor
> Fix For: 3.1.0
>
>
> Specifying "" as the last parameter for navigator.notification.prompt, the
> prompt dialog will still show "Default Text" in the text input box. However,
> putting a string of just a single space works (but also results in a space in
> the text box).
> In additional seems like the default of "Default Text" isn't the best choice
> from UX perspective. A default of an empty text box would make more sense.
> Changing line 5909 in cordova.js from:
> var _defaultText = (defaultText || "Default text");
> to
> var _defaultText = (defaultText || "");
> Resolves the issue and gives a blank text box by default. Documentation would
> also need to be updated with the new default if this is adopted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
