thomasletallec opened a new pull request #791:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/791


   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   When opening external app with inAppBrowser using target: `_system`, 
sometimes we lose the ability to go back to the initial app, as described in 
#480 
   
   Closes #480 
   Closes #735 
   
   
   ### Description
   This PR add an option `launchInNewTask` which, when used with target: 
`_system` on android, add the flag `Intent.FLAG_ACTIVITY_NEW_TASK` to the 
Intent used to launch system's browser.
   
   
   ### Testing
   I have an (proprietary) ionic/cordova app where I encountered this issue 
when opening `geo:` url with InAppBrowser.
   I checked that the issue is still here when I don't add the new option 
`launchInNewTask`, and that this issue is gone when I add `launchInNewTask=yes` 
to the options.
   
   I didn't add any new automated tests - not sure how.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to