BendingBender opened a new pull request #1006: URL: https://github.com/apache/cordova-ios/pull/1006
Fixes 991 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context The `cordova-plugin-splash-screen` allowed to hide the splash screen as a race between the timeout specified in the `SplashScreenDelay` preference and the call to `navigator.splashscreen.hide()` in JS code. This was very desireble, it allowed to show the splash screen for a long time if the application took a long time to boot but not too long so that users wouldn't think that the application is hanging. Since the reimplementation of this functionality here, the behavior has changed. Now, the `SplashScreenDelay` preference applies to calls made by `navigator.splashscreen.hide()`, defeating the behavior described above. ### Description Make hiding of splash screen a race between the timeout specified in `SplashScreenDelay` setting and `navigator.splashscreen.hide()` call again. ### Testing Manual tests in simulator and real device (iPhone X). ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] ~I added automated test coverage as appropriate for this change~ - no idea, how - [ ] ~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~ - doesn't make sense, this is a cordova-ios repo, it can only be ios-related - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
