NiklasMerz opened a new pull request #1030:
URL: https://github.com/apache/cordova-ios/pull/1030


   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   This offers plugin authors the possibilty to plug into the 
WKUrlSchemHandler. Some options where discussed on the 
[list](https://lists.apache.org/thread.html/r2df0ee4db5746960d41935833a7bd50fa750ad7c30161b76eb5bf862%40%3Cdev.cordova.apache.org%3E)
   
   I did this "hook" to implement a plugin which acts as a proxy to bypass CORS 
and cookie issues: 
https://github.com/GEDYSIntraWare/cordova-plugin-webview-proxy.
   
   Superseeds #1004 
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   The implementation was based on the discussions on the list and similarly 
implemented like `shouldOverrideLoadWithRequest`. Thanks to @erisu for the hint 
in the right direction.
   
   **TODO**
   
   Testing with more than one plugin
   Automated testing possible?
   Documentation in cordova-docs?
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   * install ios platform from this PR
   * install plugin 
https://github.com/GEDYSIntraWare/cordova-plugin-webview-proxy
   * convert http/https URL to proxy URL with 
`window.WebviewProxy.convertProxyUrl(url)`
   * check requests, console, cookie/CORS issues
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to