NiklasMerz opened a new pull request #1137:
URL: https://github.com/apache/cordova-android/pull/1137


   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   The Android Webview team suggests to use the `WebViewAssetLoader` to load 
local files. This PR is work in progress to show if this is possible and what 
needs to be considered.
   
   This has some significant benefits over using the file: scheme. Having a 
'proper' origin makes routing for frameworks like Angular work and avoids CORS 
problems.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   **TODO**
   
   - [ ] Opt-in
   - [ ] Set hostname and protocol
   - [ ] Finish [hook](https://github.com/apache/cordova-ios/pull/1030) 
integration like iOS
   - [ ] Docs
   
   Closes #1135 
   
   https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/483
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   **Unit Tests TODO!**
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to