wedgberto opened a new pull request #1154: URL: https://github.com/apache/cordova-android/pull/1154
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context Cordova has built in hook functionality that enables customisation of the build. My project has used this hook feature to change the package name via the build command line arguments so that the app can be built with the same code but different package names. e.g. io.cordova.helloworld can be installed and ran alongside io.cordova.helloworld2. This is very useful for installing test, UAT or beta releases side by side. This was possible in [email protected] but was broken by changes made in 9.0.0. When the package name of the project is changed in config.xml after a cordova build has completed, and before another build, the MainActivity.Java file is no longer moved to a folder that tracks the package name and ends up being removed. This leads to an app crash when launched because the source code for a class that extends CordovaActivity no longer exists. Subsequent build attempts of the project fail because the source code for a class that extends CordovaActivity is missing from the project. <!-- If it fixes an open issue, please link to the issue here. --> Fixes #1139 ### Description <!-- Describe your changes in detail --> This PR reinstates code that took care of moving the Java source code file containing the class that extends CordovaActivity to a folder path that matches the app's package name (e.g. app/src/main/java/**io/cordova/helloworld**). ### Testing <!-- Please describe in detail how you tested your changes. --> 1. Create a new project and set its package name to io.cordova.helloworld 2. Build the project for Android 3. Edit config.xml and set the package name to io.cordova.helloword2 4. Build the project for Android again (same command as step 2) 5. The app will build but will crash when launched on an Android device because MainActivity is missing 6. Build the project for Android again (do not alter anything, just run the exact same build command as step 5) 7. This time, the build fails with a compiler error (no class found that extends CordovaAcivity) ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
