goffioul opened a new issue #1156:
URL: https://github.com/apache/cordova-android/issues/1156


   Using [email protected], when a DOM element has requested fullscreen 
(`Element.requestFullscreen()`), installed key event handler are not executed 
anymore, until the webview exits fullscreen.
   
   For instance:
   1. create a cordova app
   2. `document.addEventListener('keydown', x => console.log(x), false)`
   3. `document.body.requestFullscreen()`
   4. generate keyboard events and inspect JS console
   
   I believe this is due to this change: 
https://github.com/apache/cordova-android/commit/71f63d7b331af07bdcbb236f28474a874383f4e8.
 In particular, `dispatchKeyEvent` from base class is not called. I would 
suggest to use this instead:
   
   ```
   @Override
   public boolean dispatchKeyEvent(KeyEvent event) {
       boolean ret = engine.getView().dispatchKeyEvent(event);
       if (! ret) {
           // If the engine didn't handle the event, handle it normally.
           ret = super.dispatchKeyEvent(event);
       }
       return ret;
   }
   ```
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [ ] I included all the necessary information above
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to