[ 
https://issues.apache.org/jira/browse/CB-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727876#comment-13727876
 ] 

ASF subversion and git services commented on CB-4480:
-----------------------------------------------------

Commit d0d4573ac630a4ee4c049df4b54bebb40d663676 in branch refs/heads/dev from 
[~agrieve]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=d0d4573
 ]

[CB-4480] Fix up a couple Unsigned->Signed mistakes from previous commit.

Also - thanks to Klaus Schmidt for the original patch for this fix.

                
> CDVFileTransfer - handling big files >2GB is not correct
> --------------------------------------------------------
>
>                 Key: CB-4480
>                 URL: https://issues.apache.org/jira/browse/CB-4480
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: 2.9.0, 3.0.0
>         Environment: iOS in general
>            Reporter: Klaus Schmidt
>            Assignee: Steve Gill
>              Labels: patch
>         Attachments: CDVFileTransfer.h.diff, CDVFileTransfer.m.diff
>
>
> Hello Cordova Team,
> we needed to download big files (>2GB) via FileTransfer and use the 
> onProgressEvent to display the progress.
> On Android everything is fine. On iOS the reported sizes in the 
> onProgressEvent are not valid, if the downloaded file is larger than 2GB:
> {{CDVFileTransfer}} uses {{NSInteger}} for {{bytesTransfered}} and 
> {{bytesExpected}}. {{NSInteger}} only is up to 2G-1 as mentioned here: 
> http://stackoverflow.com/questions/2107544/types-in-objective-c-on-iphone
> We patched the library files {{CDVFileTransfer.h}} and {{CDVFileTransfer.m}} 
> of version 2.9.0 to use "unsigned long long" - now we are able to display 
> downloads up to 16Exabytes-1byte correctly. We can see in github, that 
> version 3.0.0 has the same issue.
> I will add the diff in the issue after creating it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to