sagrawal31 commented on pull request #1173: URL: https://github.com/apache/cordova-android/pull/1173#issuecomment-807257144
> This is really good, also like that you added the comment explaining why we are adding that file Thanks for the appreciation! > and the PR checks are green which is a good sign! Kudos to you for making it green. > I just have a few nitpicks, namely the use of var keyword and I'd prefer setting up the spies in a beforeEach block since I think we'd want those two functions to be always spied on, even in potential future tests that may be added later. Makes a lot of sense. Thanks for pointing this out. > Once these changes are committed, ping me and I'll give the PR a manual test. It's done. By the time you will read this comment, yellow dots will be turned green and then you can test locally. Thanks again for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
