erisu edited a comment on pull request #1101: URL: https://github.com/apache/cordova-android/pull/1101#issuecomment-816377166
@raphinesse From a quick run test, I see a subtle difference. I haven't covered all cases but here is one example: When running the command `cordova run android --target`: The Main Branch Ending Printout: ``` Using Android SDK: /Users/cordova/Library/Android/sdk No target specified and no devices found, deploying to emulator Failed to execute shell command "getprop,sys.boot_completed" on device: Error: Command failed with exit code 1: adb -s shell getprop sys.boot_completed adb: device 'undefined' not found ``` This PR's Ending Printout: ``` Using Android SDK: /Users/cordova/Library/Android/sdk Deploying to emulator emulator-5554 Using apk: /Users/cordova/.test/someRandomProject2/platforms/android/app/build/outputs/apk/debug/app-debug.apk Package name: com.erisu.someRandomProject2 INSTALL SUCCESS LAUNCH SUCCESS ``` As seen, the warning message `No target specified and no devices found, deploying to emulator` is missing from this PR. I suspect a refactor shouldn't lose warning messages. I think improvements in visuals, such as spacing, on the other hand, are acceptable. A bonus from your PR is that it launches the emulator when the target is not provided. The main branch fails to launch even though the warning said it would launch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
