breautek opened a new pull request #1212: URL: https://github.com/apache/cordova-android/pull/1212
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixes https://github.com/apache/cordova-android/issues/1178 Depends on https://github.com/apache/cordova-android/pull/1211 The original target SDK [fix PR](https://github.com/apache/cordova-android/issues/846) didn't actually solve problem. This is because the framework and the compile SDK did not change based on the `android-targetSdkVersion` preference, resulting the default API to be downloaded and used, despite the target SDK change. ### Description <!-- Describe your changes in detail --> This is a breaking change because this PR replaces the `cdkTargetSdkVersion` and `cdvCompileSdkVersion` with a new variable, `cdvSdkVersion`, which the `android-targetSdkVersion` sets. `cdvSdkVersion` will control the android `target` API, as well as the `target SDK` and `compile SDK` settings of the android project. ### Testing <!-- Please describe in detail how you tested your changes. --> npm test & manual testing. If you remove all platform APIs, and set `android-targetSdkVersion` to 29 you should see: - upon platform add, see android 29 printed - upon cordova build, see API 29 and **only** API 29 tools downloaded. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
