breautek commented on a change in pull request #1211:
URL: https://github.com/apache/cordova-android/pull/1211#discussion_r615487164
##########
File path: bin/lib/create.js
##########
@@ -69,11 +66,19 @@ function copyJsAndLibrary (projectPath, shared,
projectName, isLegacy) {
} else {
fs.ensureDirSync(nestedCordovaLibPath);
fs.copySync(path.join(ROOT, 'framework', 'AndroidManifest.xml'),
path.join(nestedCordovaLibPath, 'AndroidManifest.xml'));
- fs.copySync(path.join(ROOT, 'framework', 'project.properties'),
path.join(nestedCordovaLibPath, 'project.properties'));
- fs.copySync(path.join(ROOT, 'framework', 'build.gradle'),
path.join(nestedCordovaLibPath, 'build.gradle'));
- fs.copySync(path.join(ROOT, 'framework', 'cordova.gradle'),
path.join(nestedCordovaLibPath, 'cordova.gradle'));
+ TemplateFile.render(path.join(ROOT, 'framework',
'project.properties'), path.join(nestedCordovaLibPath, 'project.properties'), {
+ DEFAULT_SDK_VERSION: targetAPI || constants.DEFAULT_SDK_VERSION,
+ DEFAULTS_FILE_PATH: './defaults.json'
+ });
+ TemplateFile.render(path.join(ROOT, 'framework', 'build.gradle'),
path.join(nestedCordovaLibPath, 'build.gradle'), {
Review comment:
Yah -- I must have forgot to revert. Original (unreleased) version of
this PR actually used them, but then I refactored so that the gradle
environment can just load in a JSON file itself (which allowed me to also
utilize these constants for our test environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
