PieterVanPoyer commented on a change in pull request #1228:
URL: https://github.com/apache/cordova-android/pull/1228#discussion_r628887101
##########
File path: bin/templates/cordova/lib/env/java.js
##########
@@ -96,10 +96,9 @@ const java = {
const javacPath = utils.forgivingWhichSync('javac');
const hasJavaHome = !!environment.JAVA_HOME;
if (hasJavaHome) {
- // Windows java installer doesn't add javac to PATH, nor set
JAVA_HOME (ugh).
- if (!javacPath) {
Review comment:
Nitpicking off course.
if javacPath is not used here.
The scope of the const can be smaller. Maybe place the `` const javacPath =
utils.forgivingWhichSync('javac');`` after the else { (Line 103)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
