jcesarmobile opened a new pull request #881: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/881
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ios ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> closes https://github.com/apache/cordova-plugin-inappbrowser/issues/830 ### Description <!-- Describe your changes in detail --> UIWebView handled tel, sms, mailto and geo links, but WKWebView doesn't and if the site you are loading has any of those urls on links it will just try to load them and fail android also has specific code for handling those app schemes ### Testing <!-- Please describe in detail how you tested your changes. --> app with this code `cordova.InAppBrowser.open('https://www.parsippanysbestpizza.com/', '_blank');` has a mail link on top and telephone link on the bottom, without the fix they do nothing, with the fix mail link opens mail app and tel link prompts for making a call ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
